Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extended-length prefix support #713

Merged
merged 4 commits into from
Jan 28, 2024
Merged

Add extended-length prefix support #713

merged 4 commits into from
Jan 28, 2024

Conversation

nkaretnikov
Copy link
Contributor

@nkaretnikov nkaretnikov commented Dec 19, 2023 •
edited
Loading

Fixes #588.

Description

This pull request:

  • adds support for the Windows extended-length prefix ("\\?\") via the win_extended_length_prefix option
  • adds a test
  • updates the docs.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit 5ce660b
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/65a9783fc83969000925a691

@nkaretnikov nkaretnikov added this to the challenges 🛠 milestone Dec 19, 2023
@nkaretnikov nkaretnikov force-pushed the win-extended-length-prefix-588 branch 7 times, most recently from 90f7611 to f2302cc Compare December 22, 2023 16:33
@nkaretnikov nkaretnikov marked this pull request as ready for review December 25, 2023 01:07
@nkaretnikov
Copy link
Contributor Author

@jaimergp PTAL. I'll rebase after you approve since a rebase will make it harder to review the recent changes, which is just a fixture update.

jaimergp
jaimergp reviewed Jan 24, 2024
View reviewed changes
conda-store-server/conda_store_server/app.py
@@ -120,6 +120,12 @@ def _check_build_key_version(self, proposal):
except Exception as e:
raise TraitError(f"c.CondaStore.build_key_version: {e}")

win_extended_length_prefix = Bool(
False,
help="Use the extended-length prefix '\\\\?\\' (Windows-only), default: False",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I prefer using r'' strings whenever I have backslashes in the string, but this kind of thing is better enforced by linters and style formatters rather than code reviews. Only leaving it as a statement of preference for a potential discussion down the line, not asking for a change now.

Suggested change
help="Use the extended-length prefix '\\\\?\\' (Windows-only), default: False",
help=r"Use the extended-length prefix '\\?\' (Windows-only), default: False",

@nkaretnikov nkaretnikov merged commit a2ec01e into conda-incubator:main Jan 28, 2024
18 checks passed
@nkaretnikov nkaretnikov deleted the win-extended-length-prefix-588 branch January 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp approved these changes

Assignees

@nkaretnikov nkaretnikov

Labels
area: configuration area: user experience 👩🏻‍💻 Items impacting the end-user experience project: challenges type: enhancement 💅🏼
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
challenges: Round 1 🛠
Development

Successfully merging this pull request may close these issues.

Figure out how to handle long paths on Windows
2 participants
@nkaretnikov @jaimergp